perf(aggregation): Change to proxsuite qp solver#668
Draft
PierreQuinton wants to merge 8 commits into
Draft
Conversation
PierreQuinton
added
the
cc: perf
github-actions
Bot
changed the title
Contributor
Author
|
We can run this in parallel: Simple-Robotics/proxsuite#460 I've done this in 8968715, we can try running again with this. |
Contributor
|
I think we need to have a fallback when solve_qp_in_parallel is not available, because depending on how the project is built, it won't be available. In such a case, we could: show a warning + solve sequentially. |
Contributor
|
About the failure on windows, I made an issue here: cmake-wheel/cmeel#281 |
Contributor
|
About the ty failure, it seems that there is some incompatibility between type checkers and cmeel because cmeel doesn't place the packages in the usual folder. We can probably find a workaround on our side, and if it's too bad, we can raise another issue on cmeel's repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we may want to decouple adding proxsuite and removing qpsolvers. Still this looks extremely promising.
It is possible that now we can remove regularization, which would mean more precision.