refactor!: Add DualConeProjector#678
Open
PierreQuinton wants to merge 19 commits into
Open
Conversation
PierreQuinton
added
package: aggregation
cc: refactor
Contributor
|
Need to make these projectors public and documented. I think the public linalg package would be a nice fit, but maybe an aggregation subpackage would also be cool (torchjd.aggregation.dual_cone_projection). |
ValerianRey
reviewed
May 11, 2026
Contributor
ValerianRey
left a comment
ValerianRey
left a comment
There was a problem hiding this comment.
Need changelog entry. This will be a breaking change especially if we move the norm_eps and reg_eps params to the projector. Otherwise it's breaking just for people specifying the solver (still breaking but to very few people).
ValerianRey
added
breaking-change
github-actions
Bot
changed the title
DualConeProjectorDualConeProjector
github-actions
Bot
changed the title
DualConeProjectorDualConeProjector
…mplexify class architecture later if needed.
…hting. They could be added to Projectors if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.