Skip to content
This repository was archived by the owner on Jan 18, 2020. It is now read-only.

Added: ability to change fill type#68

Open
equinox2k wants to merge 5 commits into
SixLabors:masterfrom
equinox2k:FillType
Open

Added: ability to change fill type#68
equinox2k wants to merge 5 commits into
SixLabors:masterfrom
equinox2k:FillType

Conversation

@equinox2k

@equinox2k equinox2k commented Aug 13, 2019

Copy link
Copy Markdown

Exposed ability to change fill type as per...

https://github.com/SixLabors/Shapes/issues/65

May need guide on the ImageSharp Graphics options side

@tocsoft

@CLAassistant

CLAassistant commented Aug 13, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tocsoft

tocsoft commented Aug 22, 2019

Copy link
Copy Markdown
Member

fairly certain this won't be sufficient in all cases, because our render wont necessarily use the clipper internally.
We actually use

public int FindIntersections(PointF start, PointF end, Span<PointF> buffer)
to find intersections for filling purposes thats the one that will need to be modified to support the different fill types to determine inside outsideness.

@tocsoft

tocsoft commented Aug 22, 2019

Copy link
Copy Markdown
Member

the reason the cla stuff isn't working is because the commit is seen as being created by your petertribe account but then you've signed the CLA as equinox2k its your other account that will need to sign the CLA for it to allow the commit to be merged.

@petertribe

Copy link
Copy Markdown

@tocsoft sorted out cla eventually had to create the needed account on GitHub luckily was available :)

I may need help with the FindIntersections as not sure what exactly should be done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants