Add support for Tuya thermostats#3071
Merged
Merged
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4f4b3ad |
Updated copyright information in test_tuya_thermostat.lua.
Updated copyright notice and licensing information.
hcarter-775
reviewed
Jun 29, 2026
hcarter-775
left a comment
hcarter-775
left a comment
Contributor
There was a problem hiding this comment.
mostly LGTM, withholding approval until a category is added. Thanks!
Comment on lines
+21
to
+27
| enabledValues: | ||
| - antifreezing | ||
| - auto | ||
| - comfort | ||
| - eco | ||
| - off | ||
| - on |
Contributor
There was a problem hiding this comment.
since these are configured directly in the "device_added" handler, we can drop this here to avoid too much hardcoded stuff
| deviceLabel: Tuya Thermostat | ||
| manufacturer: _TZE284_fziifcxj | ||
| model: TS0601 | ||
| deviceProfileName: thermostat No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: I see it was like this before, but newline please (as I'm already making suggestions). Thank you
Co-authored-by: Harrison Carter <137556605+hcarter-775@users.noreply.github.com>
Contributor
hi @hcarter-775 Please let us know if this is acceptable now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Adds support for Tuya thermostats.
Summary of Completed Tests
Tested
doConfigureandaddedlifecycle events, andsetHeatingSetpointandsetThermostatModecapabilities.