Skip to content

WIP: Hue lan integration tests #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varzac wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: Hue lan integration tests #3177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b3846
philips-hue: Fix a few inconsistencies with json decodingn
varzac Aug 12, 2026
38ce6b0
Add initial set of LAN integration tests for Hue
varzac Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion drivers/SmartThings/philips-hue/src/hue/api.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ local function process_rest_response(response, err, partial, err_callback)
)
end

return table.unpack(json_result, 1, json_result.n)
-- json.decode (dkjson) returns (value, next_position, error_message) -- only the first of
-- those is the decoded value this function documents returning; propagating all of them
-- here means the *parse position* gets misinterpreted as this function's `err` return by
-- every caller, on every successful decode.
return json_result[1]
else
return nil, "no response or error received"
end
Expand Down
Loading
Loading