fix(release): stamp Cargo.lock in sync-versions; publish --locked#87
Merged
Conversation
sync-versions.mjs stamped rust/fetch/Cargo.toml on release but not Cargo.lock, so the lock pinned the old version — the release worked around it with `cargo publish --allow-dirty` (no --locked, non-reproducible). Now the script also stamps the lock's smooai-fetch entry (name-targeted so dependency versions are never touched), and the publish uses --locked --allow-dirty (reproducible lock + still tolerant of the in-place manifest edits at publish time). Verified: a simulated bump stamps toml+lock together, deps untouched, cargo build --locked builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7Mn93HpqhSgEmX6tRdPAv
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same class of bug we just fixed in smooth-operator (#111): the release bumps the Rust
Cargo.tomlversion but not the lock, so the lock drifts. fetch papered over it withcargo publish --allow-dirty(no--locked, non-reproducible).Fix:
sync-versions.mjsnow also stampsrust/fetch/Cargo.lock— name-targeted to thesmooai-fetch[[package]]entry so a same-versioned dependency is never touched — and the release publishes with--locked --allow-dirty(reproducible lock;--allow-dirtystill needed because sync edits the manifests in-place at publish time).Verified: a simulated version bump stamps
Cargo.toml+Cargo.locktogether,serdeand other deps stay put, andcargo build --lockedbuilds. No-op on an already-synced tree.🤖 Generated with Claude Code