Skip to content

Add incoming sampling direction for graph transformer input contruction & anchor based PE#671

Merged
yliu2-sc merged 7 commits into
mainfrom
yliu2/incoming_tokenization
Jun 18, 2026
Merged

Add incoming sampling direction for graph transformer input contruction & anchor based PE#671
yliu2-sc merged 7 commits into
mainfrom
yliu2/incoming_tokenization

Conversation

@yliu2-sc

@yliu2-sc yliu2-sc commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Scope of work done

  • update khop sequence construction to be able to use incoming edges, as our khop sampling does incoming edge sampling
  • update the anchor based hop distance PE compute as well to enable incoming

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@yliu2-sc yliu2-sc changed the title Add incoming tokenization direction for graph transformer Add incoming sampling direction for graph transformer input contruction & anchor based PE Jun 12, 2026

@zfan3-sc zfan3-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking comment

Comment thread gigl/nn/graph_transformer.py Outdated
Comment thread gigl/nn/graph_transformer.py Outdated
Comment thread gigl/transforms/add_positional_encodings.py Outdated
Comment thread gigl/transforms/add_positional_encodings.py Outdated

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping

@yliu2-sc yliu2-sc marked this pull request as ready for review June 16, 2026 23:08
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jun 17, 2026
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jun 17, 2026
@yliu2-sc yliu2-sc enabled auto-merge June 17, 2026 05:52
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 17, 2026
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 17, 2026
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 17, 2026
@yliu2-sc yliu2-sc added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit 57b208e Jun 18, 2026
7 checks passed
@yliu2-sc yliu2-sc deleted the yliu2/incoming_tokenization branch June 18, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants