Differentiate non-missing GT pairwise bias#673
Open
yliu2-sc wants to merge 2 commits into
Open
Conversation
zfan3-sc
approved these changes
Jun 16, 2026
mkolodner-sc
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR differentiates non-missing pairwise GT attention-bias entries from missing entries.
Previously, sparse pairwise attention-bias values collapsed explicit zero-valued entries, diagonal self-pairs, and missing entries into the same
0.0value. This makes it hard for the GT attention mechanism to distinguish self relationships from absent pairwise structure.Changes
pairwise_nonmissing_indicesto Graph Transformer sequence auxiliary data.0.0.0.0without non-missing bias.GraphTransformerEncoder.Tests
ValueErrorVerification
Passed:
ruff checkon touched filesruff format --checkon touched filesgit diff --checkWhere is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO