fix(cv): make version field optional in ComicVineSearchResult#318
Open
Slepland wants to merge 1 commit into
Open
fix(cv): make version field optional in ComicVineSearchResult#318Slepland wants to merge 1 commit into
Slepland wants to merge 1 commit into
Conversation
ComicVine's API stopped including the 'version' field in search responses, causing kotlinx.serialization.MissingFieldException. Making the field nullable with a default value (String? = null) allows the serializer to gracefully handle responses missing the field without breaking metadata matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ComicVine's API stopped including the
versionfield in search responses, causingkotlinx.serialization.MissingFieldException:Every search request returns HTTP 200 but fails to deserialize, so all ComicVine metadata matching silently breaks.
Change
Made the
versionfield nullable with a default value (String? = null) so the serializer gracefully handles responses missing the field.Testing
Verified against live ComicVine API — after the fix, search results deserialize correctly even when the
versionfield is absent.Closes #... (no matching issue found)