fix(fix): make --ecosystems case-insensitive#1308
Draft
Martin Torp (mtorp) wants to merge 1 commit intov1.xfrom
Draft
fix(fix): make --ecosystems case-insensitive#1308Martin Torp (mtorp) wants to merge 1 commit intov1.xfrom
Martin Torp (mtorp) wants to merge 1 commit intov1.xfrom
Conversation
Lowercase --ecosystems input before validation so values like NPM, Npm, and npm are all accepted, mirroring --package-managers behavior. Update help text accordingly and bump patch version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ecosystemsinput before validation soNPM,Npm, andnpmare all accepted, matching the behavior already in place for--package-managers(feat(fix): add --package-managers flag #1292).--ecosystemshelp text to mention case-insensitivity.Why
--package-managerswas added in #1292 as case-insensitive (input gets uppercased before validation against an ALL-CAPS list).--ecosystems, however, validates input verbatim against an all-lowercase list, so passingNPMwould fail with "Invalid ecosystem". Asymmetric UX between two related filters; this commit makes--ecosystemsmirror--package-managers.Test plan
should accept --ecosystems case-insensitively(passesNPM,PyPI)--ecosystemsintegration tests still passeslint+tsgopass on the changed files