Skip to content

fix(scan): suppress auto-manifest hint when .socket.facts.json exists #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin Torp (mtorp) merged 2 commits into from
May 28, 2026
Merged

fix(scan): suppress auto-manifest hint when .socket.facts.json exists #1337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a80415
fix(scan): suppress auto-manifest hint when .socket.facts.json exists
mtorp May 28, 2026
dc25617
style: swap em-dash for semicolon in auto-manifest hint comment
mtorp May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/commands/scan/cmd-scan-create.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { existsSync } from 'node:fs'
import path from 'node:path'

import { joinAnd } from '@socketsecurity/registry/lib/arrays'
Expand Down Expand Up @@ -443,7 +444,15 @@ async function run(
}

const detected = await detectManifestActions(sockJson, cwd)
if (detected.count > 0 && !autoManifest) {
// Suppress the --auto-manifest suggestion when a `.socket.facts.json` is
// already present at cwd. That file is the output of `socket manifest auto`
// (and `--facts` mode of the per-ecosystem manifest commands), so suggesting
// to regenerate it would be misleading; the manifest data is already there
// and will be picked up by the scan.
const hasFactsFile = existsSync(
path.join(cwd, constants.DOT_SOCKET_DOT_FACTS_JSON),
)
if (detected.count > 0 && !autoManifest && !hasFactsFile) {
logger.info(
`Detected ${detected.count} manifest targets we could try to generate. Please set the --auto-manifest flag if you want to include languages covered by \`socket manifest auto\` in the Scan.`,
)
Expand Down
Loading