Skip to content

Refactored code in GildedRose.java by creating helper methods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sohamkl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactored code in GildedRose.java by creating helper methods #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 66 additions & 44 deletions src/main/java/com/gildedrose/GildedRose.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,54 +9,76 @@ public GildedRose(Item[] items) {

public void updateQuality() {
for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;

if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}

if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
}
Item item = items[i];

// Update quality based on item type
updateItemQuality(item);

if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
// Update sell-in date (except for Sulfuras)
if (!isSulfuras(item)) {
item.sellIn = item.sellIn - 1;
}

if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
// Handle expired items
if (item.sellIn < 0) {
handleExpiredItem(item);
}
}
}

private void updateItemQuality(Item item) {
if (isAgedBrie(item)) {
increaseQualityIfPossible(item);
} else if (isBackstagePasses(item)) {
updateBackstagePassesQuality(item);
} else if (!isSulfuras(item)) {
decreaseQualityIfPossible(item);
}
}

private void updateBackstagePassesQuality(Item item) {
increaseQualityIfPossible(item);

if (item.sellIn <= 10) {
increaseQualityIfPossible(item);
}

if (item.sellIn <= 5) {
increaseQualityIfPossible(item);
}
}

private void handleExpiredItem(Item item) {
if (isAgedBrie(item)) {
increaseQualityIfPossible(item);
} else if (isBackstagePasses(item)) {
item.quality = 0; // Backstage passes become worthless after concert
} else if (!isSulfuras(item)) {
decreaseQualityIfPossible(item);
}
}

private void increaseQualityIfPossible(Item item) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}

private void decreaseQualityIfPossible(Item item) {
if (item.quality > 0) {
item.quality = item.quality - 1;
}
}

private boolean isAgedBrie(Item item) {
return item.name.equals("Aged Brie");
}

private boolean isBackstagePasses(Item item) {
return item.name.equals("Backstage passes to a TAFKAL80ETC concert");
}

private boolean isSulfuras(Item item) {
return item.name.equals("Sulfuras, Hand of Ragnaros");
}
}