Skip to content

Chnaged the footer file to now underline the words when hovering the …#105

Merged
Embers2512 merged 1 commit into
Softeng310:mainfrom
mkee115:fix/icon-hovering
Oct 19, 2025
Merged

Chnaged the footer file to now underline the words when hovering the …#105
Embers2512 merged 1 commit into
Softeng310:mainfrom
mkee115:fix/icon-hovering

Conversation

@mkee115
Copy link
Copy Markdown
Collaborator

@mkee115 mkee115 commented Oct 19, 2025

…icon.

📌 Description

This PR improves the UI by now underlining the text when hovering over the icons in the footer. This makes it more intuitive for users that will be using the footer, to know that it is related to that text.

🔗 Related Issue(s)

Fixes #98


✅ Changes

Text is underlined when hovering over icons in the footer.

(Icon is hovered over in this image)

image

🧪 How to Test

Run either just the frontend or the front and backend, and hover over the icons in the footer.

Copilot AI review requested due to automatic review settings October 19, 2025 23:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the footer UI by implementing a coordinated hover effect where hovering over either the icon or text underlines the associated text label. The implementation uses CSS group classes to create a unified hover state across the entire link element.

Key Changes:

  • Added CSS group classes to enable coordinated hover effects between icons and text
  • Modified hover behavior to underline text when hovering anywhere on the link (icon or text)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

>
<Search className="h-4 w-4" />
<span className="hover:underline">Browse Items</span>
<Search className="h-4 w-4 no-underline" />
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-underline class is unnecessary here. Icons don't have text-decoration by default, so this class has no effect and should be removed.

Suggested change
<Search className="h-4 w-4 no-underline" />
<Search className="h-4 w-4" />

Copilot uses AI. Check for mistakes.
>
<User className="h-4 w-4" />
<span className="hover:underline">My Account</span>
<User className="h-4 w-4 no-underline" />
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-underline class is unnecessary here. Icons don't have text-decoration by default, so this class has no effect and should be removed.

Suggested change
<User className="h-4 w-4 no-underline" />
<User className="h-4 w-4" />

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@Embers2512 Embers2512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job on the change, everything works well and all tests still pass

@Embers2512 Embers2512 merged commit c8353fd into Softeng310:main Oct 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Hovering over the icons in the footer does not work

3 participants