EXIF Data remover#363
Open
chunt007 wants to merge 5 commits into
Open
Conversation
EXIF data remover module. No library required.
import { stripExifCanvas } from "./stripExifCanvas"; is the new module. No library.
This is where the upload file function/add event listener is.
Look at line 520
const sanitizedFile = await stripExifCanvas(file);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works for profile picture upload in Edit Heading
More discussion is needed as far as users uploading to their pod providers.
The user should still be able to upload png or jpg. I believe only jpg, jpeg, and webp have exif data. I did tests and it looks like it removes that data from the files successfully. Note, this should not interfere with a user's interest in uploading files directly to their pod. This is only for the profile picture. I believe users should have full control over their own data. Chances are, they can use access control to hide their data which would contain the sensitive exif data. Say a photographer might want to exchange files with other photographers regarding aperture size and camera types in the EXIF data. They probably want other users who they plan to share with to see those details. If we want to add an option for users to use the exif data remover for the drive, that is possible too. But that is a technical/user feature and carries a lot of philosophy. Please give feedback.
This profile-pane suggestion came as the result of finding out sensitive data is in profile pictures across pods. GPS data, camera type, etc to be precise. This should no longer be the case. FYI, check your pods/profile picture.
This should work for right clicking a user's pod immediately after the file has been uploaded. In the "Edit Heading" preview with the thumbnail, the profile thumbnail, and the /profile/ file location. All EXIF data should be removed.
Server-side malware scanning might be something to consider in the future for Solid. Another technical feature.