refactor: download OpenGraph images locally before sending to prevent rich media transfer failure#7
Open
Rat0323 wants to merge 1 commit into
Open
Conversation
… rich media transfer failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how GitHub OpenGraph card images are sent. Currently, the plugin yields the raw external
opengraph.githubassets.comURL to the message adapter. However, on OneBot11/NapCat platforms running in environment without global proxy settings, NapCat often fails to download the image from the blockedgithubassets.comdomain, resulting inEventChecker Failed: NodeIKernelMsgService/sendMsg (rich media transfer failed)error code 1200.This PR downloads the OpenGraph card image locally to
data/tempin Python usingaiohttp(which natively respects environment proxies withtrust_env=True), and yields the local file path to the message adapter. This ensures reliable image delivery on all platforms.