Select task FU-REBUILD-P10-T1-6: Fix uninstall.sh package detection/removal asymmetry and venv cleanup#19
Merged
Conversation
…emoval asymmetry and venv cleanup
…oval asymmetry and venv cleanup
…mmetry and add venv cleanup - Store detected pip package names in array for symmetric detection/removal - Fix dry-run to show accurate info for whichever package is installed - Parse wrapper script to detect and clean up project .venv directory
… sed for macOS compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task: FU-REBUILD-P10-T1-6 — Fix uninstall.sh package detection/removal asymmetry and venv cleanup
Commits (7 total, matching the FLOW pattern).
Changes to scripts/uninstall.sh:
1. Symmetric detection/removal — Both mcpbridge-wrapper and xcodemcpwrapper pip package names are individually detected and stored in DETECTED_PIP_PACKAGES array; removal iterates over the same array
2. Accurate dry-run output — Shows pip3 show for each actually detected package
3. Venv cleanup — Parses the wrapper script to detect if it points to a .venv, and removes it during uninstall
4. macOS compatibility — Uses POSIX-compatible sed instead of grep -oP for wrapper script parsing
Quality Gates:
∙ 296 tests pass
∙ ruff check src/ — all clear
∙ mypy src/ — no issues
∙ bash -n — syntax OK