Skip to content

FU-P13-T4-2: Implement or remove reconnect parameter in BrokerProxy#70

Merged
SoundBlaster merged 7 commits into
mainfrom
codex/feature/FU-P13-T4-2-reconnect-parameter
Feb 18, 2026
Merged

FU-P13-T4-2: Implement or remove reconnect parameter in BrokerProxy#70
SoundBlaster merged 7 commits into
mainfrom
codex/feature/FU-P13-T4-2-reconnect-parameter

Conversation

@SoundBlaster
Copy link
Copy Markdown
Owner

Description

Complete FU-P13-T4-2 by removing the unused reconnect API from BrokerProxy and aligning call sites/tests with actual runtime behavior.

Changes included:

  • Removed reconnect parameter and dead _reconnect state from BrokerProxy.
  • Removed obsolete reconnect=False argument in __main__.py proxy construction.
  • Added constructor-signature unit coverage to prevent dead reconnect API regression.
  • Completed FLOW artifacts (PRD, validation report, archive updates, review archive).

Quality gate results:

  • pytest -> 578 passed, 5 skipped
  • ruff check src/ -> pass
  • mypy src/ -> pass
  • pytest --cov -> 92.31%

Validation report:

  • SPECS/ARCHIVE/FU-P13-T4-2_Implement_or_remove_reconnect_parameter_in_BrokerProxy/FU-P13-T4-2_Validation_Report.md

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD improvement

Quality Gates

Before submitting, ensure all quality gates pass:

make check

Or run individually:

  • make test - All tests pass with ≥90% coverage
  • make lint - No linting errors
  • make format - Code is properly formatted
  • make typecheck - Type checking passes
  • make doccheck - Documentation is synced with DocC (if docs changed)

Documentation Sync

If you modified files in docs/, ensure corresponding DocC files are also updated:

docs/ file DocC file
docs/installation.md mcpbridge-wrapper.docc/Installation.md
docs/cursor-setup.md mcpbridge-wrapper.docc/CursorSetup.md
docs/claude-setup.md mcpbridge-wrapper.docc/ClaudeCodeSetup.md
docs/codex-setup.md mcpbridge-wrapper.docc/CodexCLISetup.md
docs/troubleshooting.md mcpbridge-wrapper.docc/Troubleshooting.md
docs/architecture.md mcpbridge-wrapper.docc/Architecture.md
docs/environment-variables.md mcpbridge-wrapper.docc/EnvironmentVariables.md
README.md mcpbridge-wrapper.docc/mcpbridge-wrapper.md
  • Documentation changes are synced with DocC catalog (or N/A)

Testing

  • Added/updated tests for new functionality
  • All tests pass locally
  • Manually tested the changes

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated (if needed)
  • No new warnings generated
  • PR title is descriptive

@SoundBlaster SoundBlaster merged commit 492a49f into main Feb 18, 2026
9 checks passed
@SoundBlaster SoundBlaster deleted the codex/feature/FU-P13-T4-2-reconnect-parameter branch February 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant