Skip to content

FU-P13-T2-2: Move PID file write to after successful upstream launch#72

Merged
SoundBlaster merged 8 commits into
mainfrom
codex/FU-P13-T2-2-move-pid-write-after-launch
Feb 18, 2026
Merged

FU-P13-T2-2: Move PID file write to after successful upstream launch#72
SoundBlaster merged 8 commits into
mainfrom
codex/FU-P13-T2-2-move-pid-write-after-launch

Conversation

@SoundBlaster
Copy link
Copy Markdown
Owner

Description

Implements FU-P13-T2-2 by moving PID file persistence in BrokerDaemon.start() to occur only after _launch_upstream() succeeds, eliminating a stale-lock window when startup fails mid-sequence.

Also adds a regression test for the launch-failure path and includes full FLOW artifacts for select/plan/execute/archive/review.

Validation report: SPECS/ARCHIVE/FU-P13-T2-2_Move_PID_file_write_to_after_successful_upstream_launch/FU-P13-T2-2_Validation_Report.md.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD improvement

Quality Gates

Before submitting, ensure all quality gates pass:

make check

Or run individually:

  • make test - All tests pass with ≥90% coverage
  • make lint - No linting errors
  • make format - Code is properly formatted
  • make typecheck - Type checking passes
  • make doccheck - Documentation is synced with DocC (if docs changed)

Documentation Sync

If you modified files in docs/, ensure corresponding DocC files are also updated:

docs/ file DocC file
docs/installation.md mcpbridge-wrapper.docc/Installation.md
docs/cursor-setup.md mcpbridge-wrapper.docc/CursorSetup.md
docs/claude-setup.md mcpbridge-wrapper.docc/ClaudeCodeSetup.md
docs/codex-setup.md mcpbridge-wrapper.docc/CodexCLISetup.md
docs/troubleshooting.md mcpbridge-wrapper.docc/Troubleshooting.md
docs/architecture.md mcpbridge-wrapper.docc/Architecture.md
docs/environment-variables.md mcpbridge-wrapper.docc/EnvironmentVariables.md
README.md mcpbridge-wrapper.docc/mcpbridge-wrapper.md
  • Documentation changes are synced with DocC catalog (or N/A)

Testing

  • Added/updated tests for new functionality
  • All tests pass locally
  • Manually tested the changes

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated (if needed)
  • No new warnings generated
  • PR title is descriptive

@SoundBlaster SoundBlaster merged commit 980e997 into main Feb 18, 2026
9 checks passed
@SoundBlaster SoundBlaster deleted the codex/FU-P13-T2-2-move-pid-write-after-launch branch February 19, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant