Skip to content

Fix db bootstrap logic#1180

Merged
mbuechse merged 1 commit into
mainfrom
fix-compliance-monitor-db-bootstrap
Jun 2, 2026
Merged

Fix db bootstrap logic#1180
mbuechse merged 1 commit into
mainfrom
fix-compliance-monitor-db-bootstrap

Conversation

@toothstone

@toothstone toothstone commented May 27, 2026

Copy link
Copy Markdown
Contributor

An empty db has a current version of 'None', so we have to make sure to check for that first and leave the loop before encountering the '>=' comparison to avoid a TypeError.

@toothstone toothstone force-pushed the fix-compliance-monitor-db-bootstrap branch 2 times, most recently from 6a6934b to 410250a Compare May 27, 2026 13:41
@toothstone toothstone added the bug Something isn't working label May 27, 2026
@depressiveRobot depressiveRobot removed their request for review May 29, 2026 10:38

@mbuechse mbuechse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The mistake has been spotted independently (#1171). Your solution is quite elegant.

An empty db has a current version of 'None',
so we have to make sure to check for that first and leave the loop
before encountering the '>=' comparison to avoid a TypeError.

Signed-off-by: Friedrich Zahn <friedrich.zahn@alasca.cloud>
@mbuechse mbuechse force-pushed the fix-compliance-monitor-db-bootstrap branch from 410250a to b1ac472 Compare June 2, 2026 12:47
@mbuechse mbuechse merged commit 1db1844 into main Jun 2, 2026
7 checks passed
@mbuechse mbuechse deleted the fix-compliance-monitor-db-bootstrap branch June 2, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants