Added Chinese_Xianglin_Star_Chart and Manchu sky cultures#4779
Added Chinese_Xianglin_Star_Chart and Manchu sky cultures#4779alex-w merged 26 commits intoStellarium:masterfrom
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
The Chinese_Xianglin sky culture originates from a 17th-century Chinese antique star chart. The English translations of its constellation names are consistent with those of other Chinese sky cultures. Its classification parameter is "single". The Manchu people are an ethnic minority in Northeast China. This sky culture is derived from ethnographic literature. All star names in the source material are recorded in Chinese, with no corresponding Manchu terms provided. Therefore, I believe it is necessary to include both Chinese and Manchu (reconstructed from Chinese pronunciation) in the "native" field. Its classification parameter is "ethnographic". |
|
Thank you very much for your contribution! I have a question - is it possible to add an IPA data to Chinese Xianglin sky culture? |
Of course, it is possible, and I noticed that the Chinese Song dynasty sky culture already has IPAs with identical star names, so we can simply migrate and use them. However, this might take some time. |
|  | ||
|
|
||
| *The Xianglin Star Chart (composited from 31 sectional maps)* | ||
|
|
There was a problem hiding this comment.
You could add a section ### Constellations here which could describe the figures a little more. Things you would like to tell when you explain the sky to others.
|
Thanks a lot! |
|
Regarding the IPA for the Chinese Xianglin sky culture, I have already discussed this with Sun Shuwei. I will conduct a more systematic organization and add them. If necessary, I may revise the existing IPAs in the Chinese Song Dynasty sky culture to ensure consistency. For the description of the Chinese Xianglin sky culture, I believe we can follow the approach used for Chinese Chenzhuo—briefly describing a few distinctive constellations as examples. There is no need to list them all, as the complete constellation table is already available in the Chinese sky culture. It would be sufficient to highlight only the notable differences between them in this specific sky culture. The constellation illustrations in the Manchu sky culture are indeed not essential. They are all hand-drawn star charts from field research. When creating the star lines, I referred to these images. However, some of them deviated too significantly from the actual starry sky, so I had to apply some stretching and adjustments, which resulted in two versions. The images in the description section are all the original ones. I can remove the unnecessary illustrations from the sky view and modify the filenames, displaying only all the original images in the description. |
|
Of course the hand drawings give some personal/historical touch. If they fit well (did not check yet) you can leave them in. But i know sometimes adjusting a drawing with star symbols is a nightmare. |
|
Hmm, the drawings don't really fit well, unfortunately. These should be re-made probably based on screenshots of Stellarium. Some distortions are unavoidable, but this cannot be presented to an auditorium of laypeople. You could fully remove the drawings and emulate this style with our lines: zero-length sections (only one star) are drawn by circling the star. On my European Windows the first name (sorry for my ignorance, what character set is this?) is only displayed as empty blocks. We used a certain tweak for Cuneiform. Can you identify the character script name in https://doc.qt.io/qt-6/qchar.html? |
|
Three issues:
|
It's the Manchu script. For the first character in ᡤᠠᠰᡥᠠ I get this on Ubuntu 22.04: BTW, does it not display even in the browser for you? |
|
This script is another example of a script that will break in gravity labels, e.g. ᡤᠠᠰᡥᠠ will look like so with the letters separated by spaces: "ᡤ ᠠ ᠰ ᡥ ᠠ". |
|
I see the chars here in the github website. But the Qt font database needs a little nudge. I just added "Mongolian Baiti" to the list. (Qt6.8+ only.) Gravity labels: Yes, this feature needs a rewrite for many non-Latin scripts. :-( |
thanks @Guanjin0562 for this amazing contribution! As your hand drawn images serve as a reference in scholarly work, I recommend to leave them in. @gzotti |
|
It seems we don't need to install any extra fonts. Qt has its own font database, but it may not know which fonts to apply to more exotic script systems. We can at this point not say when the next skyculture will be brought to us or which script it may use. It seems @10110111 can see the glyphs out of the box on Linux, but on Windows we must help Qt a bit in code and tell it "use font XY for xy script". I have added a fitting font for Mongolian script in master some days ago. (see above.) Of course someone could work into the future and go through the list linked in the discussion above, and decide on a stock Windows11 install which fonts to use for all these script systems, just in case. |
|
sorry for not being clear: I did not think of "installing own fonts", but allowing them to be pulled if necessary. background thought: fonts are continually developed further - our knowledge on scripts grows, laypeople will be happy with "any" cuneiform-like font that happens to float around in any public library (might that be Qt or GoogleFonts or anything else), but specialists who wish to create illustrations for their research papers may want a specific font. Not Old Babylonian but NeoAssyrian (is the most frequent issue). Of course, not all amateur astronomers and school teachers will need that - or even be able to distinguish it. So, it would be nice of us to provide the specialists with the option to pull (download or use-by-hyperlink ...) a specific font if required. |
|
I think we/ I start over-engineering... As far as I understand @Guanjin0562 , he found a workaround for Manchu SC. So, we can - in my view - just accept the SC as is for the March release. However, @gzotti, I think we could think about providing more technical options in future releases - with no urgency, of course... pretty much as for the "sky culture explorer" in the other threat ... |
|
It is also that somebody relevant here once told me the Chinese SCs traditionally have used stick figures only (of stars visible with the unaided eye). Of course, any SC author can decide to fill the sky with patterns as needed. However, only brighter stars (mag<5 with rare extensions into mag6) make sense to me for "traditional" SCs. And sorry, yes, I am just projecting that presumably many other users will have the same expectation. Questions will go to us, and we will have to write or at least coordinate the answers. So, better clarify now. |
|
No, in English the m-dash is not separated from the words—at least not in
this use case.
…On Wed, 18 Mar 2026, 20:01 Alexander V. Wolf, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In skycultures/chinese_manchu/description.md
<#4779 (comment)>
:
> @@ -54,6 +54,8 @@ The stellar nomenclature in this Manchu sky culture comprises two distinct layer
Stellarium includes over 20 of these shamanistic constellations. It also uses asterism lines to represent the *xingguans*(Chinese costellations) from official Qing dynasty star catalogs (such as the *Yixiang Kaocheng*).
+It should be noted that some of the connecting lines in the traditional Manchu asterisms—especially those representing imaginative or symbolic parts of the figures—are artistic interpretations from historical hand-drawn charts and do not correspond precisely to actual stars. In order to preserve the overall shape of these constellations as traditionally depicted, lines occasionally link to stars fainter than 6th magnitude. This does not imply that the original culture recognized or included such faint stars; it is merely a graphical means to render the envisioned form.
typo: asterisms—especially -> asterisms — especially
—
Reply to this email directly, view it on GitHub
<#4779 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQU3MRARKRLCNUATDPFZ4D4RKF2DAVCNFSM6AAAAACVUJFI4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSNRXGI4DSNZSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
English English or American English? |
You are right. For almost all traditional SCs, there is a tendency to use stars brighter than magnitude 5, and it's almost impossible for them to include stars fainter than magnitude 6.5, which are invisible to the naked eye. However, for some specific SCs, this general rule might not strictly apply. |
that's right ... the faint stars are rather brave identifications and I would be VERY careful with them in historical stick figures (with regard to their use in transdisciplinary research = use of maps by users without knowledge of the culture). However, I think, this does not really apply to the problematic cases here - this needs to be clarified in the description: you're right. |
| *Well, Ghosts, Willow, Star, Extended Net, Wings, Chariot Mansions* | ||
|
|
||
| ## Constellations | ||
|
|
There was a problem hiding this comment.
Also here: The technical structure of this section is important. The introductory text must be moved above into the ## Description. Hmm, actually all of this should be moved up. The chapter ## Constellations should consist of ##### constellation A elements only.
There was a problem hiding this comment.
So, in the Constellation section, do I really need to write an introduction to all 283 constellations, each with a five-level heading #####?
There was a problem hiding this comment.
If the goal of this section is to simply give some common information rather than describe each (or some) of the constellations, you can just make it ### Constellations. The level-2 heading is reserved for the section that contains per-constellation descriptions.
There was a problem hiding this comment.
I understand that the ## Constellations section is used for audio explanations and therefore requires strict formatting. What I'm more concerned about is the specific content of that section, specifically the introduction to each constellation. I may not be able to complete the introductions for all 283 constellations.
There was a problem hiding this comment.
This section isn't mandatory.
There was a problem hiding this comment.
The text in the ##### constel inside ## Constellations is used for display and audio output. If the program cannot identify this structure, these output elements just don't show up. The system allows very detailed explanations or storytelling, it is up to you to make use of it.
There was a problem hiding this comment.
Do I have to cover all the constellations? Can I complete a part first and gradually add more later?
There was a problem hiding this comment.
You don't "have to". Maybe start with important ones, and gradually add. You can also say OK for now and add/improve later. Just add info in the right sections please.
|
|
||
| While omitting the constellations mentioned above, the official system added new constellations near the southern celestial pole, which are not present in the *Xianglin* Star Chart. | ||
|
|
||
| In the following `Constellations` chapter, all 283 Chinese traditional constellations will be introduced. However, this introduction is *not yet complete*, as only basic information about the constellations, such as the number of stars and their locations, has been compiled. The cultural significance behind each constellation has not been fully explored in this chapter. |
There was a problem hiding this comment.
I have added a basic introduction for each constellation, following the classic text structure used in ancient Chinese books to introduce constellations. I have manually checked to ensure that the English version of each constellation corresponds to the index.json.
|
In description.md, you are using zero-width spaces, usually but not always after a |
|
Also, I see warning messages concerning constellations "Wadan (The Celestial Altar)" and "Star of Wisdom". |
…o xianglin-and-manchu-skycultures
|
I have not tested it since my last comments. Are the warnings gone? |
I see in the log: |
|
The warning message is:
Sorry my previous reply was incomplete. The constellation "Star of Wisdom" is documented in the By the way, the issue with the Wadan constellation has been resolved, with no warnings |
The entries in the description are like values in a key-value structure, where the keys are the entries in the JSON. If you try to look for a description of this constellation in e.g. the narration feature, it will not be available due to its nonexistence in the JSON file. If at some point Stellarium's UI starts behaving more like that of Stellarium Mobile, which hides all the constellation descriptions in the text and only shows them in the info panel of the selected constellation, this description of a non-existing constellation will never be shown. |
|
I think the description of a constellation that cannot be localized should go into the overall @10110111 about constellation selection: this is currently still not really intuitive, admittedly. Constellation selection currently goes only via F3 panel. Not sure if any Ctrl+Alt+Click (or whatever) on a star should select the constellation instead? For users with more than one screen, I wonder if we could make the view dialog configurable so that it could be shown on a second screen, and users could read the text without covering the screen. (Of course the RemoteControl webbrowser UI can be used now.) |
And we are back to the discussion in #4731?.. |
|
It may be less. We have already created a StelDialog for the OnlineQueries (also used by the SCM) which IIRC just has a separate window. It might be possible to extend the StelDialogs generally to use either in-Mainview or separate windows. |
Description
Added Chinese_Xianglin_Star_Chart and Manchu sky cultures.
The Chinese_Xianglin sky culture originates from a 17th-century Chinese antique star chart. The English translations of its constellation names are consistent with those of other Chinese sky cultures. Its classification parameter is "single".
The Manchu people are an ethnic minority in Northeast China. This sky culture is derived from ethnographic literature. All star names in the source material are recorded in Chinese, with no corresponding Manchu terms provided. Therefore, I believe it is necessary to include both Chinese and Manchu (reconstructed from Chinese pronunciation) in the "native" field. Its classification parameter is "ethnographic".
skycultures/CMakeLists.txtfile respectively to changes in sky cultures?index.jsonfile)?description.mdfile)?index.jsonfile)?Fixes # (issue)
None.
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
The two sky cultures can be displayed normally, including constellations, names, illustrators and descriptions.
The sky cultures do not affect other code files or the program's operation.
Test Configuration:
Checklist: