Skip to content

fix: pin publish workflow Python version to avoid pygame source build failure#16

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/pin-publish-python-version
Jul 23, 2026
Merged

fix: pin publish workflow Python version to avoid pygame source build failure#16
dmccoystephenson merged 1 commit into
mainfrom
feature/pin-publish-python-version

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • Pins publish.yml's actions/setup-python step to python-version: "3.13" instead of "3.x", matching the fix PR ci: run tests on push and pull request #14 already applied to test.yml.
  • "3.x" currently resolves to Python 3.14 on ubuntu-latest. pygame only ships prebuilt wheels through cp313, so on 3.14 pip falls back to a from-source build, which fails on the runner (missing SDL/freetype dev headers — sdl-config: not found).
  • publish.yml only runs on vX.Y.Z tag pushes, so this wasn't caught by any PR-gated CI, but it would break the "Smoke-test the built wheel" step (after the artifact is already built) on the next actual release tag.

No breaking change to the Graphik public API — this is CI-only.

Test plan

  • python3 -m compileall src/main/python
  • pip install -e .
  • pytest — 14 passed
  • Workflow YAML change only; not runnable locally, but mirrors the exact fix already verified working in test.yml (PR ci: run tests on push and pull request #14, commit efcb8d4)

Closes #15

… failure

Same root cause fixed in test.yml by PR #14: "3.x" currently resolves to
Python 3.14 on ubuntu-latest, but pygame only ships prebuilt wheels through
cp313. Without a matching wheel, pip falls back to a from-source build
that fails on the runner (missing SDL/freetype dev headers), which would
break the smoke-test step on the next tag push.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review: minimal, single-line change (plus explanatory comment) that mirrors the already-verified fix from PR #14 / test.yml exactly. No logic to break, no public API touched, local pytest suite passes (14/14). No issues found.

@dmccoystephenson
dmccoystephenson merged commit 60410bd into main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish.yml smoke-test step will fail on next tag push (unpinned 3.x + pygame no cp314 wheel)

1 participant