fix: pin publish workflow Python version to avoid pygame source build failure#16
Merged
Merged
Conversation
… failure Same root cause fixed in test.yml by PR #14: "3.x" currently resolves to Python 3.14 on ubuntu-latest, but pygame only ships prebuilt wheels through cp313. Without a matching wheel, pip falls back to a from-source build that fails on the runner (missing SDL/freetype dev headers), which would break the smoke-test step on the next tag push. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Self-review: minimal, single-line change (plus explanatory comment) that mirrors the already-verified fix from PR #14 / test.yml exactly. No logic to break, no public API touched, local pytest suite passes (14/14). No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.yml'sactions/setup-pythonstep topython-version: "3.13"instead of"3.x", matching the fix PR ci: run tests on push and pull request #14 already applied totest.yml."3.x"currently resolves to Python 3.14 onubuntu-latest. pygame only ships prebuilt wheels through cp313, so on 3.14 pip falls back to a from-source build, which fails on the runner (missing SDL/freetype dev headers —sdl-config: not found).publish.ymlonly runs onvX.Y.Ztag pushes, so this wasn't caught by any PR-gated CI, but it would break the "Smoke-test the built wheel" step (after the artifact is already built) on the next actual release tag.No breaking change to the
Graphikpublic API — this is CI-only.Test plan
python3 -m compileall src/main/pythonpip install -e .pytest— 14 passedtest.yml(PR ci: run tests on push and pull request #14, commit efcb8d4)Closes #15