Adopt Gradle best practices - #543
Conversation
📝 WalkthroughWalkthroughChangesThe Gradle build now uses Kotlin DSL configuration, Java 26 toolchains, isolated projects, jlink runtime generation, runtime-backed tests, and custom application packaging. ChangesGradle build and runtime configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
build.gradle.kts (1)
4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the public Gradle task API.
DaemonJvmPropertiesConfiguratoris an internal Gradle type. It has no compatibility guarantee. ConfigureUpdateDaemonJvmwith the public task name"updateDaemonJvm"instead. Gradle documents this public configuration method. (docs.gradle.org)Proposed fix
-import org.gradle.internal.buildconfiguration.DaemonJvmPropertiesConfigurator ... -tasks.named<UpdateDaemonJvm>(DaemonJvmPropertiesConfigurator.TASK_NAME) { +tasks.named<UpdateDaemonJvm>("updateDaemonJvm") {Also applies to: 43-46
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e6b0568c-b438-431b-a874-807f9767f60a
📒 Files selected for processing (5)
build.gradlebuild.gradle.ktsbuildSrc/build.gradle.ktssettings.gradlesettings.gradle.kts
💤 Files with no reviewable changes (2)
- settings.gradle
- build.gradle
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/resources/junit-platform.properties (1)
1-2: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winMake random test execution reproducible.
ClassOrderer.RandomandMethodOrderer.RandomuseSystem.nanoTime()as the default seed when no seed is set, so class and method ordering can differ between runs. Setjunit.jupiter.execution.order.random.seedin Gradle or CI when random ordering is required, and include the seed value in test output reports.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ecde4dc4-3cc3-4a42-82d7-da989d9809e6
📒 Files selected for processing (2)
build.gradle.ktssrc/test/resources/junit-platform.properties
🚧 Files skipped from review as they are similar to previous changes (1)
- build.gradle.kts
Summary by CodeRabbit
Chores
Tests
No changes to the application’s user-facing features or functionality.