Bump Yospace library#89
Merged
Merged
Conversation
ceyhun-o
added
🔌 connector: yospace
MattiasBuelens
requested changes
May 21, 2026
|
|
||
| private fun setupSession(session: Session) { | ||
| val isLive = session.playbackMode == Session.PlaybackMode.LIVE | ||
| private fun setupSession(session: Session, isLive: Boolean) { |
Contributor
There was a problem hiding this comment.
I think this is called sessionMode in the current SDK?
This is in the release notes for version 3.10.0:
Deprecation: enum
PlaybackMode, useSessionModeinstead.
Suggested change
| private fun setupSession(session: Session, isLive: Boolean) { | |
| private fun setupSession(session: Session) { | |
| val isLive = session.sessionMode == Session.SessionMode.LIVE |
Contributor
Author
There was a problem hiding this comment.
This is also deprecated on 3.10.0:
Deprecation: LIVE on enum SessionMode, there is no replacement.
Contributor
There was a problem hiding this comment.
Okay, but they're not going to remove that in 3.x, riiiiight?
albertonantiattheo
approved these changes
May 21, 2026
MattiasBuelens
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the Yospace library from 3.6.7 to 3.11.2.
Yospace doesn't seem to follow semver, and seem to have deprecated some APIs on 3.10.X and removed them on 3.11.X. Since our connector is compatible up to 4.X, we needed to make some changes. Mainly:
session.getPlaybackMode()andadvert.isNonLinear().consecutiveBreakTolerancewithalignConsecutiveBreaks.