Skip to content

Pass nil to native SDK when targetQuality array is empty. #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wvanhaevre merged 1 commit into from
May 29, 2026
Merged

Pass nil to native SDK when targetQuality array is empty. #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ios/THEOplayerRCTPlayerAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,14 @@ class THEOplayerRCTPlayerAPI: NSObject, RCTBridgeModule {
let quality = foundTrack.qualities.get(index)
return uids.contains { $0.intValue == quality.bandwidth } ? quality : nil
}
foundTrack.targetQualities = matchingQualities
if DEBUG_PLAYER_API { PrintUtils.printLog(logText: "[NATIVE] targetQualities: \(uids) set on active videotrack.") }
foundTrack.targetQualities = matchingQualities.count > 0 ? matchingQualities : nil
if DEBUG_PLAYER_API {
if matchingQualities.count > 0 {
if DEBUG_PLAYER_API { PrintUtils.printLog(logText: "[NATIVE] targetQualities: \(uids) set on active videotrack. (matching: \(matchingQualities.map(\.bandwidth)))") }
} else {
if DEBUG_PLAYER_API { PrintUtils.printLog(logText: "[NATIVE] targetQualities: \(uids) set on active videotrack. (no match or empty) => no quality restriction.") }
}
}
}
}
}
Expand Down
Loading