Skip to content

[TASK] Add rector, fixComposerNormalize & phpCsFixer into Bash functions#2053

Open
AnReiter wants to merge 1 commit intomainfrom
bashfunctions
Open

[TASK] Add rector, fixComposerNormalize & phpCsFixer into Bash functions#2053
AnReiter wants to merge 1 commit intomainfrom
bashfunctions

Conversation

@AnReiter
Copy link
Copy Markdown
Contributor

@AnReiter AnReiter commented Mar 28, 2026

Related ticket is #2009

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 28, 2026

Coverage Report for CI Build 25313362388

Coverage remained the same at 96.678%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 301
Covered Lines: 291
Line Coverage: 96.68%
Coverage Strength: 3.98 hits per line

💛 - Coveralls

@AnReiter AnReiter changed the title [TASK] Add for rector, fixComposerNormalize & phpCsFixer into B… [TASK] Add rector, fixComposerNormalize & phpCsFixer into Bash functions Mar 28, 2026
@AnReiter AnReiter force-pushed the bashfunctions branch 2 times, most recently from db5bb10 to 0ef2d04 Compare March 28, 2026 14:16
Comment thread Build/Scripts/runTests.sh Outdated
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Mar 28, 2026
@oliverklee oliverklee added this to the 4.1.0 milestone May 4, 2026
@AnReiter
Copy link
Copy Markdown
Contributor Author

AnReiter commented May 4, 2026

This is from last time, to innvoke the functions work, but now there are all in one. Next i will do differently, or should i change?

@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint May 4, 2026
@AnReiter AnReiter requested review from a team and cumuru and removed request for cumuru May 4, 2026 10:11
@cumuru cumuru self-requested a review May 4, 2026 10:20
@oliverklee
Copy link
Copy Markdown
Contributor

This is from last time, to innvoke the functions work, but now there are all in one. Next i will do differently, or should i change?

Please let's split this up into separate PRs - one for each function.

@oliverklee oliverklee moved this from In Review to In Progress in Best Practices code sprint May 4, 2026
@cumuru
Copy link
Copy Markdown
Contributor

cumuru commented May 4, 2026

Thanks 👍
Please see my inline comments for minor changes.
And: not all of the acceptance criteria are met yet, with checkboxes 2 and 5 of #2009 falling short…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants