refactor(lsp): remove unused LSP and Copilot wire types#1734
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0627a8a4ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return driver.escapeStringLiteral(value) | ||
| } | ||
| return value.replacingOccurrences(of: "'", with: "''") | ||
| return SQLEscaping.escapeStringLiteral(value) |
There was a problem hiding this comment.
When exporting cached query results with the SQL export plugin, this data source is constructed without a driver, so this fallback is used for every text cell. SQLEscaping.escapeStringLiteral strips \0, whereas the previous fallback only doubled quotes, so a value like "a\0b" is emitted as 'ab' and reloads as different data. Please keep the old query-result escaping semantics or encode NULs explicitly instead of dropping them.
Useful? React with 👍 / 👎.
1 participant
Removes three unused wire types from the LSP/Copilot client surface, plus the helper types that only they referenced:
LSPDidShowCompletionParams— never sent.LSPJSONRPCResponseandLSPJSONRPCError(only used by that response) — responses are decoded via concrete types.CopilotProgressParamsand itsCopilotProgressValue/CopilotProgressResult(used only by it).Each was grep-confirmed unreferenced across the app, plugins, and tests. These were flagged in the dead-code audit as possible scaffolding; removing them now since nothing uses them. They restore cleanly from git if a future Copilot feature needs them.
swiftlint --strict clean. No CHANGELOG: internal, no user-facing change.