style: remove redundant comments in RowParser (cleanup batch 1)#1736
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea81985498
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return driver.escapeStringLiteral(value) | ||
| } | ||
| return value.replacingOccurrences(of: "'", with: "''") | ||
| return SQLEscaping.escapeStringLiteral(value) |
There was a problem hiding this comment.
Preserve NUL bytes in query-result SQL exports
When exporting non-streaming query results, ExportDialog creates ExportService(databaseType:), so QueryResultExportDataSource has no driver and SQL export text cells flow through this fallback before SQLExportPlugin writes the INSERT values. Switching the fallback to SQLEscaping.escapeStringLiteral now strips embedded \0 bytes, whereas the previous implementation only doubled quotes, so a text value such as "a\0b" is exported as 'ab' and a round-trip silently loses data.
Useful? React with 👍 / 👎.
First batch of the no-comments cleanup. Removes 9 comments in
RowParserthat only restate the line below them (// Split into linesabove acomponents(separatedBy:),// Pad with NULL for missing columns, etc.). Code is untouched; the diff is comment-only.Kept on purpose: the hand-rolled CSV state-machine comments (CRLF handling, RFC 4180 escaped-quote rule) that actually help follow the scanner, and all
///doc comments and// MARK:markers.This is batch 1 of a larger sweep. See the PR discussion note about scope.