perf(welcome): index connection tree to rebuild groups in linear time#1743
Open
desperadoxhy wants to merge 1 commit into
Open
perf(welcome): index connection tree to rebuild groups in linear time#1743desperadoxhy wants to merge 1 commit into
desperadoxhy wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, you need to sign our Contributor License Agreement. To sign, please comment below with:
I have read the CLA Document and I hereby sign the CLA. xuhengyu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
WelcomeViewModel.rebuildTree 对每个 group 单独算 connectionCount / depthOf / maxDescendantDepth(各自递归全扫),buildGroupTree 每层 filter 全表,O(G²+C·G),被 18 处连接操作触发。连接/分组多时每次操作卡。
方案
新增 buildGroupTreeIndexed + computeGroupTreeIndices:一次遍历建索引,BFS 算 depth,自底向上聚合 subtree count + maxDepth,降到 O(G+C)。入口重建索引(非增量,无一致性风险)。原 buildGroupTree / connectionCount / depthOf / maxDescendantDepth 公共 API 不变。treeItems 输出结构不变。
验证