Add parallelization support.#207
Open
rolftimmermans wants to merge 5 commits into
Open
Conversation
Member
|
Hi @rolftimmermans thanks for the PR ! The changes so far look fine, with minimal impact on non-related code. I'm not sure how yet, but we need to add tests around the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports running tests in parallel, cutting down test time drastically on larger test suites.
I tested this with a nontrivial Rails app that uses PostgreSQL, with various Sequel plugins and extensions.
For pg it clones the main test database with the
templateoption to ensure the worker copies are 100% identical, including OIDs.For other db adapters the structure is loaded. I do not have a good app to test; it may or may not work well.
Ensuring that the model's
dbobjects are correct after forking seems nontrivial. Ideally there is more support fromsequelitself to do this in a robust way. If this PR is accepted I will pursue this.Feedback is very welcome. I'm eager to get this merged if possible :)