docs(router-cli,router-plugin): fix broken with-router-cli install doc links#7684
Draft
sanjibani wants to merge 1 commit into
Draft
docs(router-cli,router-plugin): fix broken with-router-cli install doc links#7684sanjibani wants to merge 1 commit into
sanjibani wants to merge 1 commit into
Conversation
…c links The 'with-router-cli' page moved out from under /framework/react/routing/installation/ in a recent docs refactor. The current canonical URL is /docs/installation/with-router-cli (which 200s for both react and solid variants via the framework prefix). Verified manually: the old /framework/react/routing/installation/with-router-cli URL returns 307 → /routing/installation/with-router-cli which then hangs (tanstack.com server is timing out on that subpath) — effectively a 404 from the user perspective. These appear as the only link in @tanstack/router-cli's README, and as the 'See ... for usage instructions' reference in @tanstack/router-plan's README (the file-based-routing link just above is also tagged with framework/react/routing/ but that one 200s after a 307 redirect, so left alone).
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two broken
tanstack.com/router/latest/docs/framework/react/routing/installation/with-router-clilinks (307 redirect chain that hangs from the user's perspective) — the page moved out from under/framework/react/routing/installation/in a recent docs refactor. Canonical URL is now/docs/installation/with-router-cli.Verified manually: the canonical URL returns 200 (and the framework-prefixed variant
/framework/react/installation/with-router-cli307-redirects to it cleanly).These appear as the only link in
@tanstack/router-cli's README, and as the 'See ... for usage instructions' reference in@tanstack/router-plugin's README. Thefile-based-routinglink just above in the plugin README is also tagged withframework/react/routing/but that one 200s after a 307 redirect, so left alone.(Note: opened as draft to work around the cross-fork
createPullRequestGraphQL permission issue on this side — same token-rotation side effect as #7672, #7678, #7679, #7683.)