fix(e2e): run Basic Auth tests against Vite preview - #8056
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Basic Auth E2E package now serves the Vite build through ChangesBasic Auth E2E execution
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/react-start/basic-auth/package.json`:
- Line 11: Update the "start" script to add Vite’s --strictPort option to the
vite preview command, ensuring it exits when the assigned $PORT is unavailable
instead of selecting another port.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f5ca99b0-f591-4c9e-9efa-b5c61443a8ab
📒 Files selected for processing (1)
e2e/react-start/basic-auth/package.json
Fixes #7798
The Basic Auth E2E package now starts its built application through the current TanStack Start Vite preview adapter on Playwright's assigned port. The issue originally suggested executing
dist/server/server.jsdirectly, but that artifact now exports a Fetch handler and exits without listening;vite previewis the project-native adapter that serves the same production build.This also removes the leading
exit 0so the E2E script actually invokes Playwright.Validation:
playwright test tests/app.spec.ts --project=chromium --grep "Posts redirects to login when not authenticated"— passed (1/1)CI=1 NX_DAEMON=false pnpm nx run tanstack-react-start-e2e-basic-auth:build --outputStyle=stream --skipRemoteCache— passed with 19 dependency tasksprettier --check e2e/react-start/basic-auth/package.json— passedgit diff --check— passedpnpm test:eslint,pnpm test:types, andpnpm test:unit— no tasks apply to this private E2E packageThe full Basic Auth suite is currently blocked before test execution by existing Prisma 7 setup/teardown files importing
PrismaClientfrom the@prisma/clientCommonJS stub. I reproduced the same discovery failure on the clean base with this script change removed, so it is outside this focused fix.No changeset is included because this only repairs scripts in a private E2E package and does not change a published package.
I used Codex to help inspect the repository and run the validation. I reviewed and adapted the final change; no separate human review was performed.
Summary by CodeRabbit