perf(router-core): use the simple interpolatePath lane on the client - #8090
perf(router-core): use the simple interpolatePath lane on the client#8090anonrig wants to merge 1 commit into
Conversation
The `$param` / `$` scan already matches the braced parser for templates
without `{...}`. Link-shaped `to`/`params` navigation can use it without
waiting for `isServer`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe path interpolation fast path no longer depends on the server environment. The implementation discards the internal ChangesPath interpolation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change routes eligible client navigation through a simpler path interpolation lane while retaining braced-segment parsing, with targeted tests listed; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Split out of #8085 so bundle size and performance can be measured independently.
The
$param/$scan already matches the braced parser for templates without{...}. Link-shapedto/paramsnavigation can use it without waiting forisServer. Braced segments still go throughparseSegment.Test plan
packages/router-core/tests/path.test.tspackages/router-core/tests/optional-path-params.test.tspackages/router-core/tests/optional-path-params-clean.test.tsSummary by CodeRabbit
$paramcontinue to resolve as expected.