refactor(*): use 'Icon'-suffixed names for all phosphor imports - #1124
Merged
Conversation
📝 WalkthroughWalkthroughThe change replaces legacy Phosphor icon aliases with explicit ChangesPhosphor icon export migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sukvvon
marked this pull request as ready for review
August 6, 2026 10:38
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | c92aa8d | Commit Preview URL Branch Preview URL |
Aug 06 2026, 10:38 AM |
SeanCassiere
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every phosphor icon is now imported under its supported
Icon-suffixed export. The bare names (Star,CaretDown, …) are deprecated by the package — each icon module carries@deprecated Use <Name>Iconon them.Why these were not caught
#1094 renamed all icons to the
Iconsuffix, and #1099 added a generateddeclare module '@phosphor-icons/react'so that the deprecated spelling became a compile error rather than a strikethrough.That declaration only covers the barrel.
@phosphor-icons/react/CaretDownis a separate module, so subpath imports resolve against the package's own types and the deprecated names are merely struck through again. When #1099 was written,src/had no subpath imports at all — the barrel was the only entry point, so locking it was sufficient. Subpath imports were introduced later, which opened a second path the guard does not cover.The guard is unchanged here; this PR only fixes the call sites. Extending it to subpaths is a separate change.
Changes
100 imports across 24 files, in three shapes:
{ Name as NameIcon }{ NameIcon }— local binding is identical, so no usage sites change{ Name as CustomName }{ NameIcon as CustomName }— the alias is kept, only the imported name moves{ Name }{ NameIcon }— no alias, so the JSX usages are renamed tooThe three custom aliases are all in
Navbar:List as Menu,Sparkle as Sparkles, andTrendUp as TrendingUp.NavbarAuthControlsimported the same module twice as{ SignIn, SignIn as SignInIcon }, with both bindings in use; they are collapsed toSignInIcon.ds/ui/index.tsxwas internally inconsistent —CaretDownIcon,CircleNotchIcon, andUserIconwere already suffixed whileMagnifyingGlassandXwere not.Verification
tsc, lint, and the unit tests pass.No deprecated phosphor name remains in the repo. This was checked across barrel imports, subpath imports, multi-line import blocks, namespace and default imports, and dynamic
import(). The generated registry and module declaration are untouched — regenerating them produces no diff.