Use a single slowpath for Brc::new#7
Draft
Techcable wants to merge 3 commits into
Draft
Conversation
On may M1 Macbook, this shrinks the size of the code from 208B to 172B, but actually reduces performance on M1 Macbook by 2%. On my Lenovo Laptop, there is no effect on performance, but reduces code size from 174B to 163B. WARNING: This patch is incomplete, as it breaks the encapsulation of runtime::threads.
Doesn't seem to help code size or performance. The old patch at least helped with the former.
This reverts commit 3f03078. Did not improve code size as expected, still seemed to harm performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On may M1 Macbook, this shrinks the size of the code from 208B to 172B, but actually reduces performance on M1 Macbook by 2%. On my Lenovo Laptop, there is no effect on performance, but it reduces code size from 174B to 163B.
WARNING: This patch is incomplete, as it breaks the encapsulation of runtime::threads.