Fix: Prevent filesystem exposure when CONTAINERS=1 - #183
Open
nedlir wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical security vulnerability where enabling
CONTAINERS=1unintentionally exposed sensitive container filesystem endpoints (such as/export,/archive, and/logs) via GET requests, allowing arbitrary file reads and full filesystem exports from any container.Changes made
haproxy.cfgfor/archive,/export, and/logsendpoints before the blanketCONTAINERSallow rule.ALLOW_ARCHIVE,ALLOW_EXPORT,ALLOW_LOGS) to control these sensitive endpoints individually, defaulting to0in the Dockerfile.ALLOW_PAUSE=0andALLOW_UNPAUSE=0definitions to the Dockerfile.README.mdand clarified the behavior ofCONTAINERS.tests/test_service.pyto verify thatCONTAINERS=1alone no longer exposes these endpoints and that enabling the specific flags correctly grants access.This ensures that tools needing basic container listing do not inadvertently gain unauthorized filesystem and log access, while preserving backwards compatibility for safe endpoints.
fixes #182