persist and use jwt for embedded mode#815
Closed
pgpbj wants to merge 1 commit into
Closed
Conversation
Member
|
Changes ported to dev-2.3.0 branch. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Short summary of what this PR does
Changes Made
The change in main-axios.ts stores the jwt coming from the user/login request to local storage so that it can later be included or appended to the requests. I don't understand how this code is supposed to work, so the change to this file is only speculative -- I assume there is a better fix.
Once I was able to create a host in local server mode, I immediately started getting "Authentication failed" errors when trying to connect to the host via SSH. This is why the fix in Terminal.tsx was required.
I tried porting these changes to the code from the dev-2.3.0 branch. They improved the behavior by allowing me to login and create hosts. However, it looks like there may be some other issue in that branch as SSH connections seem to hang and timeout.
Related Issues
Screenshots / Demos
Checklist