A1248924 mirror input example - #19
Conversation
Signed-off-by: Ayushman a-ayushman@ti.com
PR Summary by QodoAdd mirror_input + spi_10mhz AM261x examples; tighten Flow Control labels and SPI timing
AI Description
Diagram
High-Level Assessment
Files changed (92)
|
Code Review by Qodo
1.
|
| load_constant_block1.$name = "Load_Constant_0"; | ||
|
|
||
| conditional_block1.$name = "If_Else_0"; | ||
| conditional_block1.conditionToCheck = "equalToInput2"; |
There was a problem hiding this comment.
1. Non-semantic block $name values 📘 Rule violation ⚙ Maintainability
Rule 2
The new PRU0 and PRU1 SysConfig designs use generated, ambiguous type-and-index block instance names (e.g., Load_Constant_0, If_Else_0, PRU0_GPI_INSTANCE_0, PRU1_GPO_INSTANCE_0, Delay_0, Loop_0) instead of functional, purpose-oriented names. This violates Compliance ID 1 and makes reviews, wiring validation, and future edits more error-prone by increasing the chance of selecting or connecting the wrong block.
Agent Prompt
## Issue description
The PRU0 and PRU1 SysConfig designs assign generated, ambiguous type-and-index instance names (e.g., `*_0`, `*_INSTANCE_0`) instead of functional/semantic names that reflect each block’s role, increasing the likelihood of wiring/connection mistakes during review and future edits.
## Issue Context
Compliance ID 1 requires block instance names that clearly describe purpose/value (not generated naming like `Load_Constant_0`, `If_Else_0`, `Delay_0`, `Loop_0`, `PRU0_GPI_INSTANCE_0`, `PRU1_GPO_INSTANCE_0`). This is especially important when multiple similar blocks exist (e.g., multiple GPO/GPI blocks, conditionals, constants, delays/loops), where ambiguous names make it easier to select or connect the wrong block.
## Fix Focus Areas
- examples/mirror_input/firmware/am261x-lp/icss_m1_pru0_fw/example.syscfg[33-55]
- examples/mirror_input/firmware/am261x-lp/icss_m1_pru1_fw/example.syscfg[28-56]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
5a817df to
461a2a3
Compare
signed off by: Ayushman <a-ayushman@ti.com>
461a2a3 to
a8bf168
Compare
No description provided.