jpeg_rle: Add missing reset to ddstrb pipeline register to prevent spurious go after reset#4118
Open
ashnaaseth2325-oss wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
ddstrb had no reset, risking spurious go assertion to jpeg_rle1 immediately after reset release, corrupting the first JPEG block. Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Member
|
This change leads to a small QOR change. Please run |
Contributor
Author
|
Hello @maliberty, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds a missing asynchronous reset to the
ddstrbpipeline register injpeg_rle.v, preventing invalid signal propagation after reset. The change affects thejpeg_rlemodule and ensures stable interaction withjpeg_rle1by eliminating unintendedgopulses.FIX
VERIFICATION
Simulate with
rstdeasserted whiledstrbis high or unknown; previously this caused an immediate transition toacstate with invalid outputs. After the fix,ddstrbresets to 0 and no spuriousgopulse occurs. The state machine remains indcuntil valid input arrives, preserving correct JPEG block encoding.