Skip to content

jpeg_rle: Add missing reset to ddstrb pipeline register to prevent spurious go after reset#4118

Open
ashnaaseth2325-oss wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
ashnaaseth2325-oss:fix/jpeg-rle-ddstrb-reset
Open

jpeg_rle: Add missing reset to ddstrb pipeline register to prevent spurious go after reset#4118
ashnaaseth2325-oss wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
ashnaaseth2325-oss:fix/jpeg-rle-ddstrb-reset

Conversation

@ashnaaseth2325-oss
Copy link
Copy Markdown
Contributor

SUMMARY

This PR adds a missing asynchronous reset to the ddstrb pipeline register in jpeg_rle.v, preventing invalid signal propagation after reset. The change affects the jpeg_rle module and ensures stable interaction with jpeg_rle1 by eliminating unintended go pulses.


FIX

// Before
always @(posedge clk)
  ddstrb <= #1 dstrb;

// After
always @(posedge clk or negedge rst)
  if (!rst)
    ddstrb <= #1 1'b0;
  else
    ddstrb <= #1 dstrb;

VERIFICATION

Simulate with rst deasserted while dstrb is high or unknown; previously this caused an immediate transition to ac state with invalid outputs. After the fix, ddstrb resets to 0 and no spurious go pulse occurs. The state machine remains in dc until valid input arrives, preserving correct JPEG block encoding.

ddstrb had no reset, risking spurious go assertion to jpeg_rle1
immediately after reset release, corrupting the first JPEG block.

Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com>
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
@maliberty
Copy link
Copy Markdown
Member

This change leads to a small QOR change. Please run update_ok for this design and commit the updated rules file. That should get the CI passing.

@ashnaaseth2325-oss
Copy link
Copy Markdown
Contributor Author

Hello @maliberty,
Thanks! This change affects QoR as expected.
I’m currently unable to run the full OpenROAD flow locally due to tool setup issues, and I also don’t have access to Jenkins artifacts.
Could you please run update_ok and commit the updated rules?
Happy to rebase if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants