Skip to content

Update urllib3 to 2.6.0 due to CVE-2025-66418 #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maliberty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update urllib3 to 2.6.0 due to CVE-2025-66418 #4260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/AutoTuner/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ colorama==0.4.6
tensorboard>=2.17.0
protobuf>=5.26.1
SQLAlchemy==1.4.17
urllib3>=1.26.17
urllib3>=2.6.0

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 2.6.0 for urllib3 does not exist on PyPI (the latest version is 2.3.0). Specifying urllib3>=2.6.0 will cause pip install to fail because the package manager cannot find a matching version. Please use a valid, existing version of urllib3 (such as 2.3.0).

urllib3>=2.3.0

@maliberty maliberty May 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, there is a version 2.7.0 at https://pypi.org/project/urllib3/#history

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep urllib3 compatible with declared Python 3.8

When AutoTuner is installed with Python 3.8, which remains explicitly supported by tools/AutoTuner/pyproject.toml and the setup instructions, pip cannot satisfy this requirement because urllib3 2.6.0 requires Python 3.9 or newer. Consequently, installer.sh retries and ultimately fails on a declared-supported runtime; use a patched 1.26.x release for Python 3.8 via an environment marker, or raise the project's documented requires-python version together with this change.

Useful? React with 👍 / 👎.

matplotlib==3.10.0
pyyaml==6.0.1