[DO NOT MERGE] Neighbor-check CI eval: three arms (rule vs model isolation)#4368
Open
mguthaus wants to merge 2 commits into
Open
[DO NOT MERGE] Neighbor-check CI eval: three arms (rule vs model isolation)#4368mguthaus wants to merge 2 commits into
mguthaus wants to merge 2 commits into
Conversation
… + WNS) Bump tools/OpenROAD to VLSIDA neighbor-check-sta (df28de9e10) and force repair_timing -neighbor_check on for the QoR comparison. The feature is off by default upstream; this branch exists only to A/B the three arms and will be bumped through them sequentially. Signed-off-by: mrg <mrg@ucsc.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the tools/OpenROAD subproject commit and temporarily forces the -neighbor_check flag in repair_timing_helper within flow/scripts/util.tcl for CI evaluation. There are no review comments, and I have no feedback to provide.
tools/OpenROAD -> VLSIDA neighbor-check-wns (9d3b441bef). Same WNS decision rule as arm 3, lumped timing estimates instead of the subgraph STA: the diff against the arm-3 run isolates the timing model. Signed-off-by: mrg <mrg@ucsc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI QoR evaluation of the resizer neighbor feasibility check (
repair_timing -neighbor_check, off by default upstream; forced on here). Three stacked arms, bumped through this PR sequentially so consecutive diffs isolate one change each:Current head: arm 3 (df28de9e10). Replaces #4326.