Merged
Conversation
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the node and connection comparison logic from a tuple-based approach to an explicit integer-based comparison returning -1, 0, or 1. It also optimizes the 'visited' state tracking during network traversal by moving the state into the Node class itself, replacing an external std::set. A logic error was identified in the Connection::compare function where null handling was inconsistent with the rest of the comparison logic, potentially violating strict weak ordering.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 10, 2026
Comment on lines
+56
to
+57
| int compare(const Node* other) const; | ||
| int compare(const std::unique_ptr<Node>& other) const; |
Member
There was a problem hiding this comment.
Probably this should be operator<=> but that can wait for another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No functional changes, just improving the runtime of PSM.
On "large" design, check_power_grid goes from 2400s to 1800s with these changes.
There are more improvements possible, but decided this was a good checkpoint to save at.
Type of Change
Impact
Speed up
Verification
./etc/Build.sh).Related Issues
N/A