Skip to content

drt: check spacing from concave corners#10926

Open
naveenvenk17 wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-drt-concave-corner
Open

drt: check spacing from concave corners#10926
naveenvenk17 wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-drt-concave-corner

Conversation

@naveenvenk17

Copy link
Copy Markdown
Contributor

Concave LEF58 corner-spacing checks never reached the distance test. The code required the corner to be an exact corner of a maximal rectangle, but a concave point sits on the boundary of the two rectangles that form the notch.

Match concave corners against those boundary edges based on their orientation. Convex corner handling stays unchanged. The old disabled regression is enabled and expanded to cover all four notch orientations.

Testing on the GCP VM:

  • bazel test //src/drt/test:gc_unittest //src/drt/test:ta_unittest
  • bazel build --config=lint //src/drt //src/drt/test:gc_unittest
  • bazel test --config=asan //src/drt/test:gc_unittest --test_env=ASAN_OPTIONS=detect_leaks=0 with the ASan setup from bazel: fix hermetic ASan builds #10911 layered locally

The ASan run covered all 105 geometry-check tests.

Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
@naveenvenk17
naveenvenk17 requested a review from a team as a code owner July 15, 2026 16:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements concave corner overlap detection in FlexGCWorker::Impl::isCornerOverlap and introduces a parameterized test suite to verify concave corner spacing violations across all orientations. The reviewer suggests extending this concave corner handling to the second overload of isCornerOverlap to ensure consistency and prevent potential bugs.

Comment thread src/drt/src/gc/FlexGC_main.cpp
Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant