drt: check spacing from concave corners#10926
Open
naveenvenk17 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements concave corner overlap detection in FlexGCWorker::Impl::isCornerOverlap and introduces a parameterized test suite to verify concave corner spacing violations across all orientations. The reviewer suggests extending this concave corner handling to the second overload of isCornerOverlap to ensure consistency and prevent potential bugs.
Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concave LEF58 corner-spacing checks never reached the distance test. The code required the corner to be an exact corner of a maximal rectangle, but a concave point sits on the boundary of the two rectangles that form the notch.
Match concave corners against those boundary edges based on their orientation. Convex corner handling stays unchanged. The old disabled regression is enabled and expanded to cover all four notch orientations.
Testing on the GCP VM:
bazel test //src/drt/test:gc_unittest //src/drt/test:ta_unittestbazel build --config=lint //src/drt //src/drt/test:gc_unittestbazel test --config=asan //src/drt/test:gc_unittest --test_env=ASAN_OPTIONS=detect_leaks=0with the ASan setup from bazel: fix hermetic ASan builds #10911 layered locallyThe ASan run covered all 105 geometry-check tests.