Skip to content

odb: give PtrSetMap one Bazel owner#10927

Open
naveenvenk17 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-odb-ptrset-owner
Open

odb: give PtrSetMap one Bazel owner#10927
naveenvenk17 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-odb-ptrset-owner

Conversation

@naveenvenk17

Copy link
Copy Markdown
Contributor

PtrSetMap.h is exported by both //src/odb/src/db and //src/odb/src/gdsin. GDS input already depends on the db target, so its second export leaves Bazel with two owners for the same public header.

Keep the header owned by OpenDB core and let GDS input receive it through that dependency. This removes the remaining PtrSetMap.h duplicate reported by Bant and covers one item from #10409.

Testing on the GCP VM:

  • bazel test //src/odb/test:cpp_tests, all 23 C++ tests pass
  • bazel build --config=lint //src/odb/src/gdsin
  • bazel test --config=asan //src/odb/test/cpp:TestGDSIn --test_env=ASAN_OPTIONS=detect_leaks=0 with bazel: fix hermetic ASan builds #10911 layered locally
  • bant target-hdrs -e -d //src/odb/... no longer reports PtrSetMap.h

Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
@naveenvenk17
naveenvenk17 requested a review from a team as a code owner July 15, 2026 16:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused header dependency //src/odb:include/odb/PtrSetMap.h from the gdsin library target in the Bazel BUILD file. I have no feedback to provide as there are no review comments.

@osamahammad21
osamahammad21 requested review from maliberty and removed request for osamahammad21 July 16, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants