odb: give PtrSetMap one Bazel owner#10927
Open
naveenvenk17 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
osamahammad21
requested review from
maliberty
and removed request for
osamahammad21
July 16, 2026 09:39
maliberty
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PtrSetMap.his exported by both//src/odb/src/dband//src/odb/src/gdsin. GDS input already depends on the db target, so its second export leaves Bazel with two owners for the same public header.Keep the header owned by OpenDB core and let GDS input receive it through that dependency. This removes the remaining
PtrSetMap.hduplicate reported by Bant and covers one item from #10409.Testing on the GCP VM:
bazel test //src/odb/test:cpp_tests, all 23 C++ tests passbazel build --config=lint //src/odb/src/gdsinbazel test --config=asan //src/odb/test/cpp:TestGDSIn --test_env=ASAN_OPTIONS=detect_leaks=0with bazel: fix hermetic ASan builds #10911 layered locallybant target-hdrs -e -d //src/odb/...no longer reportsPtrSetMap.h