rsz: Rename strongerCellLess to weakerCellFirst()#10934
Open
jhkim-pii wants to merge 9 commits into
Open
Conversation
Correct the shared size-up comparator so lower drive resistance cells sort ahead of weaker alternatives. Rename the comparator to describe its ordering contract and update both size-up generators. Add a TestResizer regression using Nangate45 buffer strengths to lock the behavior. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Rank swappable cells using drive resistance and intrinsic delay only. Output pin capacitance is not a direct measure of drive strength and exact ties may remain equivalent. Rename the local drive variables to make the resistance metric explicit. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Rename the MoveGenerator implementation parameters from lib_ap to lib_ap_index. This matches the LibertyPort scenePort API terminology and makes the value's role as an index explicit. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Rename the MoveGenerator helper declaration parameters to lib_ap_index. This keeps the header consistent with the implementations and the LibertyPort scenePort API terminology. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the cell strength comparison logic in MoveGenerator by renaming strongerCellLess to strongerCellFirst and simplifying its comparison to only use drive resistance and intrinsic delay, removing capacitance. It also adds a unit test to verify this ordering. The reviewer suggests adding a unique integer ID as a tie-breaker in the comparison to ensure strict weak ordering and deterministic sorting when the drive resistance and intrinsic delay are equal.
Order swappable cells from higher to lower drive resistance so legacy size-up chooses the smallest improving step and MT score ties prefer it. Rename the shared comparator and update its regression test while retaining the drive-resistance and intrinsic-delay ordering keys. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Treat larger intrinsic delay as weaker when drive resistance ties so both comparator keys use descending order. Add an equal-drive Liberty fixture and regression coverage because the Nangate45 buffer family cannot isolate the intrinsic-delay tie. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
jhkim-pii
changed the title
strongerCellLess API
jhkim-pii
changed the title
strongerCellLess APIstrongerCellLess to weakerCellFirst()
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ab328afac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Permit legacy size-up to select an equal-drive replacement when its estimated stage delay improves. Extend the MT drive filter to equal resistance while retaining the strict delay-improvement check in candidate estimation and excluding the current cell. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Remove the weaker-to-stronger ordering from the multi-threaded size-up generator. The policy estimates every candidate and selects the highest score, so sorting only added unnecessary work and an implicit equal-score tie break. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Rename the current-cell drive resistance variable to drive_r in both size-up generators. This makes the resistance comparison direction explicit and avoids reading the value as drive strength. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple refactoring w/ minor tie-break logic change.
strongerCellLess()toweakerCellFirst()w/ a tie-breaker logic change.