rsz: Honor max iterations across setup endpoints#10947
Open
jhkim-pii wants to merge 1 commit into
Open
Conversation
Stop the legacy setup repair loop before starting another endpoint once the configured global iteration limit is reached. The endpoint-local check allowed one extra iteration for each remaining endpoint, so a limit of 20 could report 65 iterations. Reuse reachedIterationLimit in the outer endpoint loop and rebase the affected regression outputs. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a check in SetupLegacyPolicy::runMainRepairLoop to stop processing new endpoints once the global iteration limit is reached. This prevents unnecessary iterations and is reflected in the updated test outputs for repair_setup_crit_vt_asap7 and repair_setup_max_iter. There are no review comments, and I have no feedback to provide.
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-max_iterations.