Skip to content

Use TypeError/ValueError instead of AssertionError in simpson_integration#14836

Closed
Adichapati wants to merge 2 commits into
TheAlgorithms:masterfrom
Adichapati:wilson/20260621-use-typerror-for-validation
Closed

Use TypeError/ValueError instead of AssertionError in simpson_integration#14836
Adichapati wants to merge 2 commits into
TheAlgorithms:masterfrom
Adichapati:wilson/20260621-use-typerror-for-validation

Conversation

@Adichapati

Copy link
Copy Markdown

Replace assert statements with explicit exception handling so input validation remains active regardless of Python optimization flags (-O).

Also fix a minor bug in the original error message for the function return type check, which referenced type(a) instead of type(function(a)).

…tion

Replace assert statements with explicit exception handling so input
validation remains active regardless of Python optimization flags (-O).

Also fix a minor bug in the original error message for the function
return type check, which referenced type(a) instead of
type(function(a)).
Copilot AI review requested due to automatic review settings June 21, 2026 03:31
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Adichapati, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added invalid awaiting reviews This PR is ready to be reviewed labels Jun 21, 2026
@algorithms-keeper algorithms-keeper Bot removed the request for review from Copilot June 21, 2026 03:32
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant