Oil turns black while capturing

[DrGoldFish1]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

Issue seem to be caused by the superhackers.
Is also in GO for a while now.

Oil can turn black or dark blue for either a split second or permanently.
This is caused due to a player clicking on the oil while its being captured. If the timing is right the oil will turn black.
If the oil is not recieving any other color changing stuff while its black the oil will stay black.
This seem to only happen in network and online lobbies. Not in skirmish.

2026-06-17.16-32-52.mp4

Reproduction Steps

1. Start capturing an oil derick
2. Click on the oil while it is being captured

Additional Context

No response

[Caball009]

This is also reproducible with retail compatibility and has been an issue since #1651 AFAICT.

[Caball009]

It's reproducible in skirmish mode as well, with 30 logic timescale fps and 60 or 120 render fps.

[Caball009]

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameClient/Drawable.cpp

Lines 1334 to 1335 in 091ab3d

	if (m_selectionFlashEnvelope == nullptr)
	m_selectionFlashEnvelope = newInstance(TintEnvelope);

The following could be a possible workaround:

// Bool isResting() const { return m_envState == ENVELOPE_STATE_REST; }

if (m_selectionFlashEnvelope == nullptr)
	m_selectionFlashEnvelope = newInstance(TintEnvelope);
else if (!m_selectionFlashEnvelope->isResting())
{
	m_selectionFlashEnvelope->rest();
	m_selectionFlashEnvelope->update();
}