Remove dead Win32 constants and refresh stale no-release comments - #29
Merged
Conversation
- Program (WinForms): fold MaybeAttachConsole() into the explicit static constructor instead of an unread `_consoleAttached` field whose initializer side effect was the whole point (CA1823, and clearer about what's actually load-bearing - the beforefieldinit rationale is preserved in the comment). - MessageBoxManager/SMTree: drop the unused vendored Win32 constants (WM_DESTROY/WM_TIMER/WM_USER/DM_GETDEFID, TVM_GETEXTENDEDSTYLE) that produced CA1823 noise on every build. Zero CA1823 warnings remain. - vortex-extension: the "no GitHub Release exists yet" comments in githubRelease.ts/index.ts/toolAcquisition.ts predate v0.6.2 (live since 2026-08-11, with exactly the asset names this code expects) - reworded to reflect that, keeping the still-true parts (no eager startup download; tests never hit the network; fresh installs return false from ensureWsmToolRegistered until acquisition is triggered). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXAuGMLB44T5Zv5o5ZzKah
TheValiantOne
force-pushed
the
chore/dead-code-stale-docs
branch
from
August 11, 2026 04:02
ecc7996 to
de7447a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup unit from the hardening pass — no behavior changes.
Program(WinForms host):MaybeAttachConsole()now runs in the explicit static constructor's body instead of via an unreadstatic readonly bool _consoleAttachedfield initializer. The field's value was never read — only its initializer's side effect mattered — which both tripped CA1823 on every build and obscured the intent. Thebeforefieldinitrationale (and its "do not remove without re-verifying the repro" warning) is preserved in the comment.MessageBoxManager/SMTree: removed the unused vendored Win32 constants (WM_DESTROY,WM_TIMER,WM_USER,DM_GETDEFID,TVM_GETEXTENDEDSTYLE). The solution now builds with zero CA1823 warnings.buildAssetFileNameexpects. Reworded to current fact while keeping what's still true: no eager download on startup (that stays an explicit user action by design), tests never touch the network, andensureWsmToolRegisteredreturningfalseis the normal fresh-install state.Verification
dotnet build(0 CA1823) /dotnet test128/128 /dotnet format whitespace --verify-no-changesclean; extensiontypecheck/lint/test(200) clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01GXAuGMLB44T5Zv5o5ZzKah