chore(cua): upgrade driver to v0.13.1 - #2055
Merged
Merged
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR upgrades the bundled CUA driver from 0.12.6 to 0.13.1, updates policies and packaging, adds bounded refusal-code projections, revises token and cursor-theme guidance, removes the UIA-worker override, excludes the macOS theme sidecar, and refreshes validation coverage. ChangesCUA 0.13.1 upgrade
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CUA Driver
participant ToolManager
participant cuaToolAdapter
participant DeepChat Model
CUA Driver->>ToolManager: return structuredContent
ToolManager->>cuaToolAdapter: provide tool name and result
cuaToolAdapter->>cuaToolAdapter: validate refusal.code
cuaToolAdapter->>DeepChat Model: append snapshot and bounded refusal projections
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/architecture/plugin-external-runtime-lifecycle/plan.md`:
- Around line 114-116: Resolve the conflicting driver versions in the plan by
updating the earlier pin requirement in Section 7 to cua-driver-rs-v0.13.1, or
explicitly marking it as historical foundation work if that version must remain.
Ensure the document has one unambiguous current target consistent with Section
11.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 77999e7f-77d4-4256-8207-9c8a5e11f0ce
📒 Files selected for processing (29)
docs/architecture/plugin-external-runtime-lifecycle/plan.mddocs/architecture/plugin-external-runtime-lifecycle/spec.mddocs/architecture/plugin-external-runtime-lifecycle/tasks.mddocs/features/cua-cross-platform-computer-use/spec.mddocs/features/cua-cross-platform-computer-use/tasks.mdplugins/cua/mcp/cua-driver.jsonplugins/cua/plugin.jsonplugins/cua/policies/tool-policy.jsonplugins/cua/skills/computer-use/README.mdplugins/cua/skills/computer-use/SKILL.mdplugins/cua/skills/computer-use/TESTS.mdplugins/cua/skills/computer-use/WEB_APPS.mdplugins/cua/vendor/cua-driver/upstream.jsonscripts/build-cua-plugin-runtime.mjsscripts/package-plugin.mjssrc/main/mcp/toolManager.tssrc/main/plugin/cuaEmbeddedAdapter.tssrc/main/plugin/cuaToolAdapter.tstest/main/agent/deepchat/runtime/toolAdapters.test.tstest/main/mcp/toolManager.test.tstest/main/plugin/cuaEmbeddedAdapter.test.tstest/main/plugin/cuaRuntimeIntegrity.test.tstest/main/plugin/cuaToolAdapter.test.tstest/main/plugin/pluginService.test.tstest/main/plugin/toolCatalog.test.tstest/main/scripts/buildCuaPluginRuntime.test.tstest/main/scripts/packagePlugin.test.tstest/renderer/plugins/cuaSettings.test.tstest/renderer/stores/mcpStore.test.ts
💤 Files with no reviewable changes (3)
- plugins/cua/mcp/cua-driver.json
- src/main/plugin/cuaEmbeddedAdapter.ts
- test/renderer/stores/mcpStore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the bundled CUA driver from v0.12.6 to v0.13.1 across macOS, Windows, and Linux, and align DeepChat with the updated native tool contracts.
Changes
set_agent_cursor_stylewithset_agent_cursor_theme.sessionfor cursor state, motion, and theme operations;get_agent_cursor_statewith the new response shape.browser_type.replacesupport, including empty-text field clearing.cua-cursor-themeauthoring sidecar and fail closed unlessContents/MacOScontains onlydeepchat-cua-driver.start_sessioncalls free ofcursor_theme; explicit appearance changes useset_agent_cursor_theme.element_tokenvalues without changing valid indices, coordinates, or unrelated falsy arguments.structuredContentwhile projecting boundedrefusal.codevalues into model-visible content.stale_element_token,generation_mismatch, andinvalid_element_tokenby taking one fresh snapshot and retrying with its replacement token.pagecontract.Known v0.13.1 limitation
launch_appandkill_appuse per-session ownership internally, but their public schemas omit thesessionfield. As a result, a schema-conforming owned-process termination cannot succeed in standard mode.DeepChat therefore:
kill_app;This should be revisited after upstream exposes
sessionin the affected schemas.Summary by CodeRabbit
browser_typereplace behavior) including screenshot inclusion gating.kill_app) for the 0.13.1 tool contract.