Audit fixes#111
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds audit-related fixes to improve YAML frontmatter handling during HTML export and introduces a comprehensive Markdown feature verification document for manual regression testing.
Changes:
- Update HTML export flow to parse YAML frontmatter and prepend a rendered metadata table to the exported HTML.
- Add export-time CSS for
.frontmatter-tableso the metadata table is styled in exported HTML. - Add
test.md, a Markdown verification & test suite document covering frontmatter, Mermaid, MathJax, GFM, and custom extensions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| test.md | Adds a manual verification/test suite document (frontmatter, Mermaid, MathJax, GFM, extensions). |
| script.js | Prepends rendered frontmatter table to HTML export output and adds export-only frontmatter table CSS. |
| desktop-app/resources/js/script.js | Mirrors the same HTML export + CSS changes for the desktop bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4298
to
+4300
| const { frontmatter, body } = parseFrontmatter(markdownEditor.value); | ||
| const tableHtml = frontmatter ? renderFrontmatterTable(frontmatter) : ''; | ||
| const html = tableHtml + marked.parse(body); |
Comment on lines
+4399
to
+4403
| .frontmatter-table { | ||
| width: 100%; | ||
| border-collapse: collapse; | ||
| margin-bottom: 24px; | ||
| font-size: 14px; |
Comment on lines
+4298
to
+4300
| const { frontmatter, body } = parseFrontmatter(markdownEditor.value); | ||
| const tableHtml = frontmatter ? renderFrontmatterTable(frontmatter) : ''; | ||
| const html = tableHtml + marked.parse(body); |
Comment on lines
+4399
to
+4403
| .frontmatter-table { | ||
| width: 100%; | ||
| border-collapse: collapse; | ||
| margin-bottom: 24px; | ||
| font-size: 14px; |
|
|
||
| ### Currency Delimiter Collision Test | ||
| *Standard currency symbols must NOT compile as LaTeX equations:* | ||
| - I bought this book for $5 and that markdown guide for $10. (Should render as standard text with raw dollar signs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.